[4.4] Add model exception for components to start using#41809
Merged
HLeithner merged 2 commits intojoomla:4.4-devfrom Sep 20, 2023
Merged
[4.4] Add model exception for components to start using#41809HLeithner merged 2 commits intojoomla:4.4-devfrom
HLeithner merged 2 commits intojoomla:4.4-devfrom
Conversation
Member
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This comes from #38949.
Summary of Changes
Adds an exception interface that can be used by components looking to use exceptions rather than LegacyErrorTrait. We want to add this into an earlier version as possible (i.e. J4) so as we roll out exceptions in j5. extension developers can still catch these exceptions in J4 and require 4.4 or higher.
Testing Instructions
N/A Review class is present. See sample code in linked PR but we will not use this interface until 5.x in core.
Link to documentations
This will be documented once the exceptions have been created for J5 and a note will be added to those docs that exception handling can be ported into extensions and still be 4.4 compatible
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed